Selenium-Remote-Driver icon indicating copy to clipboard operation
Selenium-Remote-Driver copied to clipboard

Published 20 hours ago • verified publisher icon teodesian

Fix #329 -- Uninitialized value warnings in S::R::Commands

Open troglodyne opened this issue 7 years ago • 3 comments

It just wasn't setting sane defaults before running regex replace. This commit additionally adds test coverage for the modified subroutine, hopefully in the correct place.

I also added a block to properly include the libdir when running the affected test via prove (so that you don't have to use -Ilib or something like that) whenever we're not running the test via 'dzil test' or anything else where we've plopped the libs and tests in a temporary '.build' directory.

troglodyne avatar Aug 10 '17 03:08 troglodyne

Coverage Status

Coverage decreased (-0.1%) to 73.688% when pulling eae31ccbdd81e328113977295952fab7fa96230e on troglodyne:SRD-329 into f9f6d9469e09d593f48c483883d0540069748dd5 on teodesian:master.

coveralls avatar Oct 31 '17 02:10 coveralls

K, updated the test for review commentary. Speeds up t/04-commands-implemented.t by 1s due to not reading in all three files every time you searched for one command.

troglodyne avatar Oct 31 '17 03:10 troglodyne

Coverage Status

Coverage decreased (-0.1%) to 73.688% when pulling a4fa22a022ed08c89c4dfa274c866a781e321922 on troglodyne:SRD-329 into f9f6d9469e09d593f48c483883d0540069748dd5 on teodesian:master.

coveralls avatar Oct 31 '17 04:10 coveralls