tt-metal
tt-metal copied to clipboard
[Feature Request] Remove flatbuffers from exposed headers
Is your feature request related to a problem? Please describe.
Currently UMD pulls in the flatbuffers
library which is in turn pulled in by CPM. This leads to integrating TTNN from a 3rd party C++ library difficult as the 3rd party project also has to pull in the same version of flatbuffers via CPM or other means. Since the flatbuffers is not used in any API. It would be great to hide flatbuffers from headers.
This is a deal breaker for me as I cannot use CPM in GGML. Nor I can expect distros to happen to use the same version of flatbuffers as TTNN is using.
I have opened 2 PR, one in UMD and one in tt-metal to address the issue. The two PRs does the following respectively
- Hide flatbuffers from UMD header
- Include the generated flatbuffers in tt-metal cpp file
The TTNN PR must be merged before UMD is merged and pulled in.
Arguably this is a long(-er) discussion. But I still want to put my patches out and see how can we work towards a solution.
Describe the solution you'd like Do not expose flatbuffers in UMD header.
Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Additional context Add any other context or screenshots about the feature request here.