tensorzero icon indicating copy to clipboard operation
tensorzero copied to clipboard

Added an Add as Demonstration button to the inference TryWithVariant modal

Open virajmehta opened this issue 6 months ago • 7 comments

should use the same pattern as the existing HumanFeedbackForm so wasn't too complicated


[!IMPORTANT] Added a button to submit demonstration feedback in the inference modal and updated UI tests to handle credentials.

  • UI Components:
    • Added DemonstrationFeedbackButton in DemonstrationFeedbackButton.tsx for submitting demonstration feedback.
    • Updated VariantResponseModal in VariantResponseModal.tsx to include DemonstrationFeedbackButton.
  • Routes:
    • Modified route.tsx to handle demonstration feedback submission and navigation.
    • Added prepareDemonstrationFromVariantOutput() to process variant output for feedback.
  • Testing:
    • Updated .github/workflows/ui-tests-e2e.yml to run UI E2E tests requiring credentials.
    • Added e2e test in observability.inferences.$inference_id.spec.ts for adding demonstration feedback via the "Try with variant" flow.

This description was created by Ellipsis for 6bf8da8cff16da69326055c005affe8e36269e8a. You can customize this summary. It will automatically update as commits are pushed.

virajmehta avatar Jun 11 '25 15:06 virajmehta

/regen-fixtures

virajmehta avatar Jun 20 '25 17:06 virajmehta

/regen-fixtures

virajmehta avatar Jun 20 '25 19:06 virajmehta

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Jun 22 '25 22:06 github-actions[bot]

/regen-fixtures

Aaron1011 avatar Jun 23 '25 15:06 Aaron1011

recheck

Aaron1011 avatar Jun 23 '25 15:06 Aaron1011

/regen-fixtures

virajmehta avatar Jun 23 '25 17:06 virajmehta

/regen-fixtures

virajmehta avatar Jun 25 '25 19:06 virajmehta

/regen-fixtures

virajmehta avatar Jul 23 '25 15:07 virajmehta

Moved button:

CleanShot 2025-07-29 at 09 45 07@2x

GabrielBianconi avatar Jul 29 '25 13:07 GabrielBianconi