tensorzero icon indicating copy to clipboard operation
tensorzero copied to clipboard

Add tests with `tensorzero::tags` to `openai-go`

Open GabrielBianconi opened this issue 6 months ago • 4 comments

See the tests for openai-python and openai-node that use tensorzero::tags and create a similar test for openai-go.

https://github.com/tensorzero/tensorzero/blob/main/clients/openai-python/tests/test_openai_compatibility.py

https://github.com/tensorzero/tensorzero/blob/main/clients/openai-node/tests/openai-compatibility.test.ts

GabrielBianconi avatar Jun 11 '25 14:06 GabrielBianconi

Hi, I'd like to work on this issue. Could you please assign it to me?

anesmeftah avatar Jun 25 '25 21:06 anesmeftah

Hi @anesmeftah - thank you for the interest, as you're a first-time contributor, please submit a PR directly!

GabrielBianconi avatar Jun 26 '25 15:06 GabrielBianconi

I'm working on this

HJStaiff avatar Jun 29 '25 23:06 HJStaiff

Hi @HJStaiff - thank you for your interest! We'll look forward to a PR.

GabrielBianconi avatar Jun 30 '25 13:06 GabrielBianconi

@GabrielBianconi Can issues be assigned once a person expresses interest? That way it's easier to filter on unassigned issues. Perhaps un-assign if the assigned person doesn't provide a PR within X days?

michaldorsett avatar Jul 05 '25 20:07 michaldorsett

Hi @michaldorsett - we used to do that in the past, but the majority of people who requested to be assigned never sent a PR, and it was tough to keep track of "stale assignments." For now we're not explicitly assigning issues to people who haven't contributed, though PRs are welcomed!

GabrielBianconi avatar Jul 05 '25 21:07 GabrielBianconi

Hi! I’ve started looking into this issue. I’ll post updates here as I make progress.

beimnettes avatar Jul 09 '25 02:07 beimnettes

Hi! I'm currently assigned to this issue, and after reviewing the repo, I found that the compatibility test for openai-go (including tensorzero::tags) already exists in openai_compatibility_test.go.

Just wanted to confirm if this issue is still open for additional work or if it's already been completed. Happy to help further if needed!

beimnettes avatar Jul 09 '25 04:07 beimnettes

@beimnettes I don't see it? Where?

GabrielBianconi avatar Jul 09 '25 04:07 GabrielBianconi

@GabrielBianconi The test is in: clients/openai-go/tests/openai_compatibility_test.go , There are several test cases that use the tensorzero:: format for example, in the TestBasicInference function, call:

req.WithExtraFields(map[string]any{ "tensorzero::episode_id": episodeID.String(), })

There are also other tests using tensorzero::function_name::basic_test, tensorzero::variant_name, and similar tags. Let me know if I misunderstood the issue or missed something.

beimnettes avatar Jul 09 '25 04:07 beimnettes

We need a test that covers tensorzero::tags specifically (literally), see the other files for Python and Node for example.

GabrielBianconi avatar Jul 09 '25 04:07 GabrielBianconi

I’ll go ahead and add a new test that specifically uses tensorzero::tags, similar to what’s in the Python and Node tests.Appreciate the guidance I’ll follow up shortly with the changes!

beimnettes avatar Jul 09 '25 04:07 beimnettes