tensorly icon indicating copy to clipboard operation
tensorly copied to clipboard

Tensor PLSR

Open aarmey opened this issue 3 years ago • 2 comments
trafficstars

aarmey avatar Jul 28 '22 19:07 aarmey

Codecov Report

Merging #435 (b17f3ba) into main (1128fea) will decrease coverage by 0.00%. The diff coverage is 83.96%.

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   88.77%   88.76%   -0.01%     
==========================================
  Files         109      111       +2     
  Lines        6430     6648     +218     
==========================================
+ Hits         5708     5901     +193     
- Misses        722      747      +25     
Impacted Files Coverage Δ
tensorly/regression/cp_plsr.py 67.67% <67.67%> (ø)
tensorly/regression/tests/test_cp_plsr.py 98.21% <98.21%> (ø)
tensorly/regression/__init__.py 100.00% <100.00%> (ø)
tensorly/decomposition/tests/test_tucker.py 100.00% <0.00%> (ø)
tensorly/tenalg/proximal.py 67.68% <0.00%> (+0.23%) :arrow_up:
tensorly/cp_tensor.py 85.08% <0.00%> (+0.43%) :arrow_up:
tensorly/decomposition/_tucker.py 90.83% <0.00%> (+0.53%) :arrow_up:
tensorly/tenalg/svd.py 88.80% <0.00%> (+4.79%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 28 '22 20:07 codecov[bot]

Thanks @MarieRoald! @cyrillustan, I believe we are using the N-PLS construction, right? We are also generalizing this to work for >3-mode X. We will add an explanation to the docstring.

aarmey avatar Jul 29 '22 14:07 aarmey

@JeanKossaifi @MarieRoald this should be ready for your review again!

aarmey avatar Sep 13 '22 20:09 aarmey

I think this broke the doc

JeanKossaifi avatar Sep 22 '22 22:09 JeanKossaifi

@JeanKossaifi, yes, I saw that error. It looks like it is in the COVID example, which this doesn't touch, which is a little strange. Regardless, I'm looking into it.

aarmey avatar Sep 23 '22 14:09 aarmey