indexify icon indicating copy to clipboard operation
indexify copied to clipboard

Rename indexify cli to indexify-executor

Open earhart opened this issue 7 months ago • 5 comments

earhart avatar Jun 06 '25 18:06 earhart

Sorry, what's the rationale for this? We have 3 subcommands in indexify-cli now (see my PR). We need all 3 for OSS users to build images, deploy worfklows and run executors.

eabatalov avatar Jun 06 '25 18:06 eabatalov

I was talking with Diptanu about the codebase, and specifically the various CLIs -- I haven't looked too closely at them, but I'm thinking I'll need to in order to implement the retry policy things we've discussed. He suggested the renaming to make it more clear what was going on.

earhart avatar Jun 06 '25 18:06 earhart

Thank you for explaining. In tensorlake SDK we use subcommands of tensorlake command. We can rename indexify-cli into indexify and keep using the subcommands:

indexify build-image
indexify deploy
indexify executor

But I don't see any other ideas here tbh.

Also I'm not sure how retries are related to CLIs. We already have retries defined in tensorlake SDK. This is purely SDK concept, not CLI.

eabatalov avatar Jun 06 '25 19:06 eabatalov

Also merging the two CLIs (tensorlake and indexify is not worth it as they are doing different things). But sharing code base. Usually tensorlake does more things on top of what indexify is doing (I'm about build-image and deploy subcommands only).

eabatalov avatar Jun 06 '25 19:06 eabatalov

We had some issues and discussed internally. We decided that we want to split Indexify CLI and Executor PyPi packages so Executor package doesn't depend on Tensorlake SDK anymore so Tensorlake SDK dependencies don't trickle into Executor package. This is a sizable project because it'll require setting up a new Executor pacakge (we can use existing Indexify package for the CLI). We'll also need to generate Py proto files for FE in Executor package to not rely on Tensorlake SDK proto tooling version.

eabatalov avatar Jun 16 '25 16:06 eabatalov