tfx-addons icon indicating copy to clipboard operation
tfx-addons copied to clipboard

Published 20 hours ago • verified publisher icon tensorflow

filter component commit

Open vulkomilev opened this issue 3 years ago • 3 comments

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • [ ] Tests pass
  • [ ] Appropriate changes to README are included in PR

vulkomilev avatar Aug 09 '22 08:08 vulkomilev

Thanks for the PR! :rocket:

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

github-actions[bot] avatar Aug 09 '22 08:08 github-actions[bot]

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Oct 12 '22 15:10 review-notebook-app[bot]

Also generally, why not use a Beam pipeline to do so vs this numpy filter?

casassg avatar Oct 12 '22 16:10 casassg

I don't understand. Iris_example_colab.ipynb is the example notebook from the feature selection component. Why is it included here?

rcrowe-google avatar Nov 01 '22 21:11 rcrowe-google

I don't understand. Iris_example_colab.ipynb is the example notebook from the feature selection component. Why is it included here?

it will be removed.

vulkomilev avatar Nov 02 '22 21:11 vulkomilev

made a new push @casassg

vulkomilev avatar Feb 17 '23 19:02 vulkomilev

@vulkomilev Here are the steps to finish the component PR:

  • Update copy right in all files of your component
  • Update tests, make sure they run and remove anything Pandas Transform related
  • run the linter and make sure that the linter is green on Github!
  • update the example notebook with an example csv file, load the csv data, and apply the filter component, and print the content of the TFRecords (the first 4 samples)
  • resolve all conversations above which you have addressed, leave the ones open for which you have questions. That helps to quickly review the PR.

Thank you!

hanneshapke avatar Apr 13 '23 16:04 hanneshapke