tflite-micro icon indicating copy to clipboard operation
tflite-micro copied to clipboard

Add int16 support to PACK/UNPACK

Open andresovela opened this issue 1 year ago • 6 comments

This PR adds int16 support for PACK and UNPACK ops.

bug=#2736

andresovela avatar Oct 29 '24 14:10 andresovela

Not sure what's the deal with the failing CI

andresovela avatar Oct 31 '24 08:10 andresovela

"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

github-actions[bot] avatar Dec 10 '24 10:12 github-actions[bot]

Needs review

andresovela avatar Dec 10 '24 10:12 andresovela

"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

github-actions[bot] avatar Jan 20 '25 10:01 github-actions[bot]

Needs review

andresovela avatar Jan 20 '25 12:01 andresovela

Addressed concerns :)

andresovela avatar Mar 04 '25 13:03 andresovela

Sorry for delayed review!

suleshahid avatar Jun 02 '25 18:06 suleshahid

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks.

You may have to fix your CI before adding the pull request to the queue again. If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again. If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Jun 02 '25 18:06 mergify[bot]

Ah, seems like Unpack int16 support was added in #3028 . Could you refactor?

suleshahid avatar Jun 02 '25 18:06 suleshahid

Ah, seems like Unpack int16 support was added in #3028 . Could you refactor?

@andresovela

Please remove the unpack.cc changes in your PR and keep in the PR the unpack_test.cc changes you made, as the test code was not submitted in PR #3028.

ddavis-2015 avatar Jun 02 '25 19:06 ddavis-2015

Hi @ddavis-2015, unfortunately priorities have changed at work and I no longer have time to work on this. Feel free to close the PR if it's already outdated.

andresovela avatar Jun 02 '25 20:06 andresovela