tfjs
tfjs copied to clipboard
tensorflow
Rescaling Preprocessing Layer
Co-authored-by: David Kim (@koyykdy) [email protected] Brian Zheng (@Brianzheng123) [email protected]
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is 
Looks like this is failing CI due to tslint. You can run the linter locally by running yarn lint in the root of the repository.
@mattsoulanille We have made the requested changes and signed a CLA agreement on behalf of Codesmith. Please let me know if there is anything else we can do. Thanks!
@AdamLang96 LGTM on the code side of things. Thanks for making the formatting and testing changes.
One last question on the legal side of things. The corporate CLA that CodeSmith signed was signed by someone with the title "Engineering Fellow." Are they authorized to sign on behalf of CodeSmith?
Just to make sure I had Alex Zai, the co-founder of Codesmith, resubmit the CLA. There should be two on file now so I apologize for the confusion.
Thanks! We received the signature on our side. I'll merge this PR ~~now~~ edit: once another team member takes a look, and future ones should be a lot easier.
@mattsoulanille @Linchenn I was wondering if it is possible to run a single unit test within tfjs-layers. As of right now i am running yarn test in tfjs-layers which runs all unit tests and havent figured out how to run a specific _test.ts file. Thanks!
Could you try grep? For example, use yarn test --//:grep='linear activation' in tfjs-layers to test https://github.com/tensorflow/tfjs/blob/master/tfjs-layers/src/activations_test.ts#L19
@AdamLang96, It looks like this branch is out-of-date with the base tfjs branch. If you allow edits from maintainers, we can update the branch and get it merged. Alternatively, you can update the branch and ping me, but it might take a few rounds since we don't have a commit queue yet.
@mattsoulanille I am updating the branch as we are having some issues with github allowing edits from maintainers (I think this is due to us making a PR from an organization's fork and not a personal fork). We have invited you as a contributor to our repo which will hopefully fix the problem.
@AdamLang96 Thanks! Invitation accepted. I'll merge this once CI passes (and update the branch again if necessary).