tfjs icon indicating copy to clipboard operation
tfjs copied to clipboard

[webgpu] Handling validation error

Open axinging opened this issue 3 years ago • 2 comments

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

axinging avatar Aug 30 '22 02:08 axinging

@qjia7 @xhcao @haoyunfeix @gyagp PTAL

axinging avatar Aug 30 '22 05:08 axinging

I think it will impact the performance if you unconditionally add pushErrorScope and popErrorScope. Do you observe any perf loss?

And in another side, I don't see we can catch the error in time and have to delay it when executing getBufferData. In this case, I can also get the similar message in console as the warning without this PR. So what's the advantage of the PR?

Yes, I am also thinking about if we should add a validation flag on this.

I think warning here is misleading. This kind of validation error should be fixed immediately, and abort running. And the validation error in dawn is generated async, do you have any better place (instead of getBufferData) to get these errors?

axinging avatar Aug 31 '22 02:08 axinging