tfjs icon indicating copy to clipboard operation
tfjs copied to clipboard

Published 20 hours ago • verified publisher icon tensorflow

Remove fromPixelsAsync

Open gyagp opened this issue 3 years ago • 3 comments

WebGPU no longer relies on async createImageBitmap for fromPixels, so the async version is no longer needed.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

gyagp avatar Jun 30 '22 09:06 gyagp

@qjia7 @shaoboyan PTAL

gyagp avatar Jun 30 '22 09:06 gyagp

fromPixelsAsync is technically part of the public API, so we should deprecate it instead of deleting it. I don't think anyone else is using it, but it's probably better to save this for the 4.0 major release. I'll follow up with instructions on how to include this in 4.0. Please leave the PR open until I do that.

mattsoulanille avatar Jul 06 '22 23:07 mattsoulanille

@mattsoulanille thanks!

gyagp avatar Jul 07 '22 00:07 gyagp

@mattsoulanille Can we add this into next major release (5.0)?

gyagp avatar Oct 17 '22 02:10 gyagp

Yes. We'll have a longer merge process for 5.0 than we had for 4.0, and we'll accept breaking changes from contributors. This PR should go in 5.0, which we plan to release some time in the next few months. 4.0 was merged with only the TypeScript upgrade because it needed to be merged quickly to resolve some internal issues.

mattsoulanille avatar Oct 17 '22 18:10 mattsoulanille