tfjs
tfjs copied to clipboard
[wasm] add the default dtype for tf.fill (#5656)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
I'm willing to help, but I do not understand the meaning of the test file, and I do not know how to actually run these tests.
Do you have any introduction or tutorial resources that can help me to understand the test configuration? Thank you😄
Hi @tiandeyu-github, thank you! For this, you need to add {startsWith: 'fill '}, (note the extra space after "fill") to the end of the TEST_FILTERS array here. This will ask the WASM backend to run tests whose names start with "fill " which are defined here.
@@ -433,6 +433,7 @@ const TEST_FILTERS: TestFilter[] = [
{include: 'image.transform'},
{include: 'batchToSpaceND'},
{include: 'spaceToBatchND'},
+ {startsWith: 'fill '},
];
After that, under the tfjs-backend-wasm directory, run:
$ yarn
$ yarn test
This should eventually start a chrome which will run all the wasm tests. I tried it in the master branch and it complains about Unknown dtype undefined in all the "fill" tests, which should be fixed by your PR.
(If running tests locally on your machine doesn't work due to certain environment setup issues, you could also try pushing it here and check on the cloud build result)
Please give it a try and let me know any problems. Thanks!