Added files for mod kernel
I made a P.R for mod kernel and solves this issue #5110
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
Build failed due to formatting/lint error, not related to xnnpack (google/XNNPACK#1613) I think. You can see it on the build log.
Build failed due to formatting/lint error, not related to xnnpack (google/XNNPACK#1613) I think. You can see it on the build log.
Can you tell me how to resolve lint error
You can just look at the build log or run yarn run lint locally inside tfjs-backend-wasm directory. This command will output the log contain information of which line causes the error and what action is needed to fix the error.
Still I think so there is some logic error after I resolve lint error
binary_f32(a_id, b_id, out_id,
[ ](float a, float b) {
float mod = fmod(a, b);
if ((a < 0 && b < 0) || (a >= 0 && b >= 0)) {
return mod;
} else {
return fmod((mod+b) , b);
}
});
This is the logic which I am applying for that
any updates on this one?
any updates on this one?
I also have a conversation with xnnpack repo moderator too for this mod kernel is not supporting https://github.com/google/XNNPACK/pull/1613
Can you implement mod kernel in TFJS first? I guess it would take long to implement in XNNPACK.
WASM implementation has been added through #4236 and #7670 . Please let me know if you run into other issues with this op, and thanks for your contributions!