tfjs icon indicating copy to clipboard operation
tfjs copied to clipboard

added the error message change as mentioned in T1165

Open dhirensr opened this issue 4 years ago • 7 comments

changed the error message as mentioned in https://github.com/tensorflow/tfjs/issues/1165 also tested in locally with yarn build, format, lint and test.


This change is Reviewable

dhirensr avatar Mar 09 '20 16:03 dhirensr

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 09 '20 16:03 googlebot

Is this PR complete yet?

jayeshmann avatar Aug 18 '21 16:08 jayeshmann

Thank you for your contribution! If you are still interested in adding this code, please sign the CLA.

jenperson avatar Sep 06 '22 15:09 jenperson

@jenperson : the work is done and reviewed right. what's the blocker for merge?

dhirensr avatar Sep 09 '22 12:09 dhirensr

There is one more email which is used for commit , please sign the cla with that email as well image

rthadur avatar Sep 09 '22 14:09 rthadur

@rthadur : I don't have access to that email anymore. is there a way to remove that? would removing the commit and fixing on a new commit work?

dhirensr avatar Sep 11 '22 00:09 dhirensr

@dhirensr please resubmit the changes in a new PR if possible using one email which you signed CLA. Thank you

rthadur avatar Sep 12 '22 13:09 rthadur

I think this is issue solved @jenperson already fixed on @tensorflow/[email protected] https://github.com/tensorflow/tfjs/blob/tfjs-v4.10.0/tfjs-layers/src/engine/training.ts#L170

we can close this PR

rubiagatra avatar Sep 05 '23 13:09 rubiagatra