tfjs-node icon indicating copy to clipboard operation
tfjs-node copied to clipboard

Published 20 hours ago • verified publisher icon tensorflow

Remove dist importing

Open WenheLI opened this issue 5 years ago • 4 comments

This pr is to remove dist importing and add no-import-from-dist rule.

This change is Reviewable

WenheLI avatar Jul 24 '19 08:07 WenheLI

Ah looks like those exports don't actually exist... cc @annxingyuan did we start exporting these for WebGPU?

nsthorat avatar Jul 25 '19 14:07 nsthorat

@nsthorat There is a corresponding PR for the extra exports. https://github.com/tensorflow/tfjs-core/pull/1856

WenheLI avatar Jul 25 '19 14:07 WenheLI

Thanks for this PR! We're waiting on 1.2.8 @tensorflow/tfjs to be published before we can merge this.

nkreeger avatar Aug 14 '19 17:08 nkreeger

Let's reopen this PR on the monorepo once we move tfjs-node there because we'll have a top-level tslint folder which we can share among every package.

1.2.8 is also a large change for tfjs-node which will take some time for us to do.

nsthorat avatar Aug 19 '19 13:08 nsthorat