tfjs-models icon indicating copy to clipboard operation
tfjs-models copied to clipboard

universal-sentence-encoder packages update

Open erikyo opened this issue 1 year ago • 3 comments

To use this model with the current version of tfjs it is needed to update this package to a version 4 or higher. for the same reason i updated other dependencies from the tests everything works correctly

Summarizing:

  • Package version updated to 1.3.4
  • TensorFlow Updated to >4
  • Typescript to >5
  • some additional dependencies like jasmine, rimraf, ts-node have been updated in order to ensure better functionality and safety

erikyo avatar Dec 22 '23 22:12 erikyo

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 22 '23 22:12 google-cla[bot]

We really need this update. Is there a collaborator to check this? @pyu10055 , your help would be valuable and would be appreciated. Thank you.

ram-you avatar Jan 05 '24 07:01 ram-you

@ram-you completely understand and since I was in the same situation and needed it for an experiment (example) I redid the USE package as I needed it. I keep it as long as it is needed and then deprecate it in favor of this one when it is updated (it doesn't matter with this pr or not, I just made it to push it a bit since it really needs an update)

erikyo avatar Jan 07 '24 17:01 erikyo