tensorflow icon indicating copy to clipboard operation
tensorflow copied to clipboard
Published 2 weeks ago • verified publisher icon tensorflow

[TOSA] Fix tfl.transpose_conv legalization when layer has bias

Open tom-arm opened this issue 2 years ago • 20 comments

This PR fixes the legalization of tfl.transpose_conv in the case where the layer has a non-zero bias.

tom-arm avatar Aug 07 '23 15:08 tom-arm

Hi @rsuderman Can you please review this PR ? Thank you!

gbaned avatar Aug 24 '23 06:08 gbaned

Thank you for the review @jpienaar, I have posted replies to your comments.

tom-arm avatar Oct 12 '23 12:10 tom-arm

Hi @jpienaar, Can you please review this PR ? Thank you!

gbaned avatar Nov 03 '23 06:11 gbaned

Hi @jpienaar, could you review this PR please? Thanks!

tom-arm avatar Nov 30 '23 16:11 tom-arm

Hi @jpienaar, Can you please review this PR ? Thank you!

gbaned avatar Dec 15 '23 06:12 gbaned

Hi @jpienaar, Can you please review this PR ? Thank you!

gbaned avatar Dec 29 '23 08:12 gbaned

Hi @jpienaar, could you review this PR please? Thanks!

tom-arm avatar Jan 23 '24 10:01 tom-arm

Hi @rdzhabarov, can you review this PR please? Thanks!

tom-arm avatar Feb 26 '24 10:02 tom-arm

Hi @jpienaar, Can you please review this PR ? Thank you!

gbaned avatar Mar 08 '24 16:03 gbaned

Hey @jpienaar, could you review this PR please? Many thanks!

tom-arm avatar Mar 21 '24 15:03 tom-arm

Hey @jpienaar, could you review this PR please? Thanks in advance!

tom-arm avatar Apr 15 '24 14:04 tom-arm

Hi @tom-arm Can you please resolve conflicts? Thank you!

gbaned avatar Apr 26 '24 08:04 gbaned

This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

github-actions[bot] avatar May 11 '24 01:05 github-actions[bot]

Hi @gbaned, the conflict is fixed now. It would be good to get this reviewed if possible

tom-arm avatar May 14 '24 08:05 tom-arm

Hi @jpienaar, Can you please review this PR ? Thank you!

gbaned avatar May 29 '24 06:05 gbaned

Hi @jpienaar, Can you please review this PR ? Thank you!

gbaned avatar Jun 07 '24 16:06 gbaned

Hi @jpienaar, Can you please review this PR ? Thank you!

keerthanakadiri avatar Jul 09 '24 07:07 keerthanakadiri

Hi @jpienaar, Can you please review this PR ? Thank you!

keerthanakadiri avatar Jul 17 '24 04:07 keerthanakadiri

Hi @jpienaar, Can you please review this PR ? Thank you!

keerthanakadiri avatar Aug 07 '24 05:08 keerthanakadiri

Hi @jpienaar, Can you please review this PR ? Thank you!

keerthanakadiri avatar Aug 28 '24 07:08 keerthanakadiri

Hi @jpienaar, Can you please review this PR ? Thank you!

keerthanakadiri avatar Sep 03 '24 07:09 keerthanakadiri

Hi @jpienaar, Can you please review this PR ? Thank you!

keerthanakadiri avatar Sep 18 '24 04:09 keerthanakadiri

Hi @jpienaar, Can you please review this PR ? Thank you!

keerthanakadiri avatar Oct 03 '24 09:10 keerthanakadiri

Hi @jpienaar, Can you please review this PR ? Thank you!

keerthanakadiri avatar Oct 09 '24 10:10 keerthanakadiri

Hi @jpienaar, Can you please review this PR ? Thank you!

keerthanakadiri avatar Oct 23 '24 12:10 keerthanakadiri

@tom-arm can you update this PR to solve the conflict so that we proceed with reviewing this one?

leandron avatar Feb 05 '25 16:02 leandron

@mihaimaruseac I reopened a few of these TOSA related patches so that we can get them updated, reviewed and hopefully merged soon. (cc @jpienaar)

leandron avatar Feb 10 '25 09:02 leandron

@tom-arm can you solve the conflict here so that we can get this reviewed and potentially merged soon?

leandron avatar Feb 10 '25 10:02 leandron

@leandron thank you, that makes complete sense. I wanted to close stale PRs, but if someone is looking at them then definitely let's progress them in.

mihaimaruseac avatar Feb 10 '25 14:02 mihaimaruseac

The code change from this PR has already been merged in this PR: https://github.com/tensorflow/tensorflow/pull/87273. cc @leandron @mihaimaruseac @tom-arm We can close this PR now.

Jerry-Ge avatar Feb 26 '25 22:02 Jerry-Ge