tensorflow icon indicating copy to clipboard operation
tensorflow copied to clipboard

Published 20 hours ago • verified publisher icon tensorflow

[TF-TRT] Disable TF32 for TF-TRT unittests that needs it

Open DEKHTIARJonathan opened this issue 2 years ago • 6 comments

TF32 computation may require in some cases a higher threshold to pass some unittests. Instead of implementing some complex logic, the standard procedure for these few cases is to test in FP32 instead of TF32 and not modifying the threshold.

This PR corrects some TF-TRT unittests with this logic

DEKHTIARJonathan avatar Jun 16 '22 18:06 DEKHTIARJonathan

@bixia1 for review

DEKHTIARJonathan avatar Jun 16 '22 18:06 DEKHTIARJonathan

@bixia1 I pushed the changes requested, can you re-approve ? Thanks

DEKHTIARJonathan avatar Jun 29 '22 16:06 DEKHTIARJonathan

@DEKHTIARJonathan Can you please check @bixia1's comments and keep us posted ? Thank you!

gbaned avatar Jul 08 '22 16:07 gbaned

@DEKHTIARJonathan Any update on this PR? Please. Thank you!

gbaned avatar Jul 22 '22 16:07 gbaned

@DEKHTIARJonathan Any update on this PR? Please. Thank you!

gbaned avatar Aug 05 '22 15:08 gbaned

@DEKHTIARJonathan Any update on this PR? Please. Thank you!

gbaned avatar Aug 09 '22 13:08 gbaned

@bixia1 comments fixed, good for review

DEKHTIARJonathan avatar Aug 10 '22 22:08 DEKHTIARJonathan

I am waiting for the author to address my comments.

bixia1 avatar Aug 12 '22 22:08 bixia1

@DEKHTIARJonathan Any update on this PR? Please. Thank you!

gbaned avatar Sep 02 '22 18:09 gbaned

@DEKHTIARJonathan Any update on this PR? Please. Thank you!

gbaned avatar Sep 16 '22 16:09 gbaned

@DEKHTIARJonathan Any update on this PR? Please. Thank you!

gbaned avatar Oct 14 '22 19:10 gbaned

@bixia1 could you review again ? All conflicts have been solved

DEKHTIARJonathan avatar Oct 18 '22 15:10 DEKHTIARJonathan