tensorboard icon indicating copy to clipboard operation
tensorboard copied to clipboard

Published 20 hours ago • verified publisher icon tensorflow

Group colours by regex of the experiment name.

Open AnuarTB opened this issue 1 year ago • 1 comments

Motivation for features / changes

Users want to color runs by the regex string of the corresponding to runs experiment names.

Technical description of changes

  • Added new GroupBy type, REGEX_BY_EXP.
  • Added a dropdown in dialog window, so users could select between regex for run name or experiment name.

Screenshots of UI changes (or N/A)

N/A since internal change.

Detailed steps to verify changes work correctly (as executed by you)

  • Run tensorboard.corp server.
  • Click on color grouping icon and select Regex.
  • Select Experiment Name in dropdown.

Alternate designs / implementations considered (or N/A)

N/A

AnuarTB avatar May 03 '24 05:05 AnuarTB

@hoonji I will certainly try then remove the formatting of the BUILD files in this PR. Regarding the change you requested.

  1. at least split the made code into two separate PRs (e.g. redux code first, then the rest)

Does it just mean separate the formatting of the files and added feature code?

AnuarTB avatar May 03 '24 16:05 AnuarTB

@AnuarTB I mean separating out the actions, effects, reducers and utils into a separate PR, and putting the component/container logic in a followup PR.

I think it's silly to spend too much effort just splitting code, but we should prefer it in cases like this where a split is easy and natural.

hoonji avatar May 07 '24 03:05 hoonji

I mean separating out the actions, effects, reducers and utils into a separate PR, and putting the component/container logic in a followup PR.

+1 This PR is quite large. It would be very helpful to review if you separated this PR into two parts.

roseayeon avatar May 07 '24 04:05 roseayeon

Ok so If I understood correctly, I should separate store, actions and reducers into first PR and then the views in the second PR? If that's so I will separate now, I was just confused on how should i separate this CL, as it is one big coherent block of code.

AnuarTB avatar May 07 '24 04:05 AnuarTB

I should separate store, actions and reducers into first PR and then the views in the second PR?

Yeah Exactly

If that's so I will separate now, I was just confused on how should i separate this CL, as it is one big coherent block of code.

How about putting all the other code in one PR, and the code under views/runs_table in a second PR? Does it sound okay?

roseayeon avatar May 07 '24 06:05 roseayeon

Have separated Model and View parts to separate PRs. When this PR is submitted, will submit: #6847

AnuarTB avatar May 07 '24 09:05 AnuarTB