tensorboard icon indicating copy to clipboard operation
tensorboard copied to clipboard

Angular Component Migration

Open JamesHollyer opened this issue 2 years ago • 0 comments

Motivation for features / changes

The legacy components are being deprecated. This is a big step in moving to the new components

Technical description of changes

This was done with a complicated find and replace which included manual pruning. After the find and replace the only other changes are in the mat-slider components as the new mat-sliders have a completely different structure with the thumb as a child component. This mat-slider change in the image card allowed for a cleanup of some weird logic.

Significantly I also change the mat.all-legacy-component-themes call to mat.all-component-themes in the _tb_theme.template.scss file.

This PR causes a lot of styling issues which will need to be resolved before syncing or releasing.

Screenshots of UI changes (or N/A)

Screenshot 2023-08-16 at 10 32 51 AM Screenshot 2023-08-16 at 10 33 34 AM

Detailed steps to verify changes work correctly (as executed by you)

Alternate designs / implementations considered (or N/A)

JamesHollyer avatar Aug 16 '23 17:08 JamesHollyer