similarity icon indicating copy to clipboard operation
similarity copied to clipboard
verified publisher icon tensorflow

Google Summer of Code

Open abhisharsinha opened this issue 3 years ago • 2 comments

This work was part of my Google Summer of Code project. The following are the major contributions of the project.

  • Addition of multiple negatives ranking loss
  • Addition of an example notebook for fine-tuning CLIP using multiple negatives ranking loss

abhisharsinha avatar Sep 12 '22 09:09 abhisharsinha

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Sep 12 '22 09:09 review-notebook-app[bot]

Thanks for the PR! I'll review the notebook soon and I left a few comments on the loss.

owenvallis avatar Sep 22 '22 06:09 owenvallis

@abhisharsinha, let me know your thoughts on the PR comments and we can get this merged into the dev branch.

owenvallis avatar Oct 03 '22 00:10 owenvallis

Thanks for updating the loss. I meant to revert the changes to pyproject.toml but accidentally deleted the file. The change in the line-length was causing the Black formatting checks to fail.

Can you please add pyproject.toml back with the following, thanks.

[tool.isort]
profile = "black"

[tool.black]
 line-length = 119

owenvallis avatar Oct 21 '22 04:10 owenvallis

Looks like the Black and Isort formatting checks are failing for tensorflow_similarity/losses/multinegrank_loss.py. Otherwise looks good to go, thanks.

owenvallis avatar Oct 23 '22 04:10 owenvallis