similarity icon indicating copy to clipboard operation
similarity copied to clipboard

projector: add notebook renderer

Open stephanwlee opened this issue 4 years ago • 3 comments

This change introduces Python API to render the new projector in Juypter notebook. It currently provides work in progress API, embedding which visualizes the embedding data and label rendered in the visualization.

In order to support both Colab and Jupyter, I have decided to introduce an abstraction, Renderer which knows how to render an output cell and how to communicate with it. Do note that Jupyter and Colab are very different; Jupyter does not encapsulate JavaScript context for each output cell so a symbol exposed on globalThis bleeds over to other output cells while Colab does not do that.

stephanwlee avatar Oct 28 '21 23:10 stephanwlee

I think were just missing some type annotations. Looks like the static typing tests are failing for tensorflow_similarity/visualization/projector_v2/notebook.py:71

owenvallis avatar Nov 01 '21 17:11 owenvallis

Thanks for taking a look at the CI. I am doing the work on the side and will get to it when ready. Also, will mark the PR as "Ready for review" when it is truly ready.

stephanwlee avatar Nov 01 '21 17:11 stephanwlee

Sounds good, thanks!

owenvallis avatar Nov 02 '21 17:11 owenvallis