serving icon indicating copy to clipboard operation
serving copied to clipboard

Fix ignoring git branch in Dockerfile.devel and Dockerfile.devel-gpu

Open gallir opened this issue 11 months ago • 1 comments

The build argument TF_SERVING_VERSION_GIT_BRANCH was ignored in both dockerfiles, although it was correctly handled in .devel-mkl.

I just copied&pasted the same "git clone" lines from mkl. Now the command

docker build --pull -t $USER/tensorflow-serving-devel --build-arg TF_SERVING_VERSION_GIT_BRANCH="r2.18" -f tensorflow_serving/tools/docker/Dockerfile.devel .

uses the right branch.

Note: I realised it because there's a bug in tensorflow_serving/serving.bzl introduced two months ago by https://github.com/tensorflow/serving/commit/2c9e66b26e579258945bc3efe186a83e092485fd. I wanted to compile with r2.18 but the ARG in docker build didn't work and always used master.

gallir avatar Jan 21 '25 00:01 gallir

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 21 '25 00:01 google-cla[bot]