serving icon indicating copy to clipboard operation
serving copied to clipboard

Add support for CentOS based Docker images

Open mohsenrezaeithe opened this issue 5 years ago • 9 comments

Feature Request

Describe the problem the feature is intended to solve

Based on the interest in the community and in my team on supporting the TF serving [service] on CentOS, I'm interested in introducing Docker based CentOS (7+) artifacts to the repository, and I wanted to gauge the interest in the community on committing the effort back to the repository to be maintained by the contributors.

We've managed to build TF serving from ground up on CentOS and would love to contribute it back to the repo, if that's inline with the future of the repository. This is especially important as most of the guidelines and instructions on the web are either out-of-date or lacking the full build instructions. It seems to be a value add to the repository if a second popular OS was officially supported.

Some related discussions:

  • #1251
  • #1227
  • #1182
  • #1082
  • #942
  • #930

Describe the solution

A set of Dockerfile* instructions for CentOS that'd potentially match those available under the current Docker tools for Ubuntu.

Describe alternatives you've considered

This request is based on the strict need for using CentOS as the underlying OS. Given that Ubuntu is out-of-date as of 46e49bb, Ubuntu was also far-fetched as a second option to CentOS.

Additional context

Ideally, the CentOS based Docker images would also be published alongside the Ubuntu ones.

mohsenrezaeithe avatar Jan 29 '20 23:01 mohsenrezaeithe

Thanks for filing this feature request. Provided there is enough interest from the community to take ownership of this in terms of maintenance etc., we're definitely open to considering it.

christisg avatar Feb 28 '20 04:02 christisg

I'll help with maintenance and ownership.

magick93 avatar Feb 29 '20 02:02 magick93

I started a PR to achieve this (#1566). @magick93 we can iterate on this to get the build working on TF's master.

@christisg for the sake of automation, I need help setting up checks and release pipelines so we'd get Docker images automatically.

mohsenrezaeithe avatar Mar 07 '20 17:03 mohsenrezaeithe

I will be more than happy to help to get this merged and maintain it in future as well.

aaur0 avatar Jun 22 '20 10:06 aaur0

Any process now ?

DachuanZhao avatar Sep 27 '20 07:09 DachuanZhao

Thanks for filing this feature request. Provided there is enough interest from the community to take ownership of this in terms of maintenance etc., we're definitely open to considering it.

Hi , I see the PR in https://github.com/tensorflow/serving/pull/1566 , Why is it blocked ? Could you please check it ?

DachuanZhao avatar Sep 27 '20 07:09 DachuanZhao

The checks need to be updated to include CentOS build. As of now, it's still expecting an Ubuntu build (and still pending a run): image

@christisg how do you recommend to go about the checks for this change?

mohsenrezaeithe avatar Jan 05 '21 22:01 mohsenrezaeithe

Hi, I opened #1894 it builds the images successfully and resolves the build issues mentioned in #1566.

MrAta avatar Jul 15 '21 01:07 MrAta

@mohsenrezaeithe

Could you please respond on the above @MrAta comment. Thanks

pindinagesh avatar Nov 29 '21 15:11 pindinagesh