rust icon indicating copy to clipboard operation
rust copied to clipboard

Published 20 hours ago • verified publisher icon tensorflow

Enable to use newer protobuf

Open dskkato opened this issue 2 years ago • 3 comments

  • remove protobuf version restriction
  • fix CI

Closes #414

dskkato avatar Sep 12 '23 13:09 dskkato

@adamcrume Could you check this PR if you have time?

dskkato avatar Sep 12 '23 15:09 dskkato

The problem is that the generated code (which is checked in) is only compatible with the exact same version of protobuf that generated it. This is a very annoying property of the protobuf crate, but I can't change that.

We could switch to generating the code in a build script, which means that we need the proto files available at build time. We could do that by adding TensorFlow as a git submodule, but it's huge (hundreds of megabytes), and apparently cargo doesn't work well with submodules (https://github.com/rust-lang/cargo/issues/7987). Possibly a better way is to just manually (with a script) copy the protos from TensorFlow into this crate for each version upgrade.

adamcrume avatar Sep 16 '23 22:09 adamcrume

hmmm https://github.com/tensorflow/rust/blob/master/src/protos/allocation_description.rs#L1-L1

dskkato avatar Sep 17 '23 00:09 dskkato