rust icon indicating copy to clipboard operation
rust copied to clipboard

crates.io version of tensorflow-internal-macros has incorrect dependency versions.

Open brianjjones opened this issue 3 years ago • 2 comments

The Cargo.toml has the correct dependencies, however crates.io appears to have not been updated. If I use tensorflow-internal-macros = "0.0.1" in my project, it imports proc-macro2 v0.4.30, quote v0.6.13, syn v0.15.44, and unicode-xid v0.1.0.

This doesn't prevent me from building, but I have a project I want to create a PR for that requires there not be any duplicate crates in the lockfile. Can you please update crates.io so that this is no longer an issue?

brianjjones avatar Dec 28 '21 02:12 brianjjones

Hm, it looks like I've been ignoring tensorflow-internal-macros during releases. I'll update the release instructions to fix that.

The tensorflow-internal-macros crate is entirely internal and should not be depended on directly. Can you provide a bit more detail in how you're running into this issue?

adamcrume avatar Dec 31 '21 04:12 adamcrume

I'm just including tensorflow = "0.17.0" in my Cargo.toml, not using tensorflow-internal-macros directly. I did a quick test of making a new rust hello world project via cargo init, then added tensorflow = "0.17.0" to it. After building, my cargo tree -d shows several duplicate packages because of the older versions being pulled in by tensorflow-internal-macros.

brianjjones avatar Dec 31 '21 17:12 brianjjones