rust icon indicating copy to clipboard operation
rust copied to clipboard

Test set_bool_list/get_bool_list

Open adamcrume opened this issue 4 years ago • 6 comments

In the operation_attributes test in graph.rs, set_bool_list and get_bool_list should be tested.

adamcrume avatar Jan 04 '21 19:01 adamcrume

Hi, @adamcrume! I'm working on this issue. Could you please assign it to me? I'm a newb at this, but I have started writing the code.

whereistejas avatar Jan 06 '21 10:01 whereistejas

Am I required to sign the CLA before the issue is assigned to me?

whereistejas avatar Jan 06 '21 10:01 whereistejas

You'll have to sign the CLA before I review the pull request. You can go ahead and send the pull request whenever you're ready, and the CLA bot will tell you if it checks out or not.

adamcrume avatar Jan 07 '21 03:01 adamcrume

is this available? I'd be interested in having a go at it.

Heidar-An avatar Jul 17 '23 21:07 Heidar-An

https://github.com/tensorflow/rust/pull/291 hasn't been updated in a couple of years, so I'd say this is available. I mentioned in https://github.com/tensorflow/rust/pull/291#pullrequestreview-564013073 that it's actually a bit difficult:

Whoops, I'm sorry, I forgot this is actually difficult to fix at the moment. The test won't pass unless we use a real op and a real attribute, and I missed a comment in the code that mentions that there aren't any built-in ops with list(bool) attributes (which I just double-checked).

We could create a custom op and load it, but that can be difficult, because it has to be written in C++, and linking that in is tricky.

You're welcome to work on this, but I'm going to remove the "good first issue" label.

adamcrume avatar Jul 18 '23 02:07 adamcrume

It sounds pretty complex, so I might skip this for now (hopefully, I can come back to it a few months down the line :)) is there anything a beginner could start helping with? even something like documentation or something else introductory / not too hard to do, just so I can get a taste of the codebase.

Heidar-An avatar Jul 18 '23 10:07 Heidar-An