Fix for triangular_solve BEF executable unit test failure on ROCm.

Open rsanthanam-amd opened this issue 3 years ago • 2 comments

/cc @chsigg @hanbinyoon

Apr 28 '22 05:04 rsanthanam-amd

Nit: Could we please initialize a_num_elements to n * n? Something like:

int32_t a_num_elements = n * n; if ((platform == wrapper::Platform::CUDA && side_mode == CUBLAS_SIDE_LEFT) || (platform == wrapper::Platform::ROCm && side_mode == rocblas_side_left)) a_num_elements = m * m;

Otherwise, looks good! :)

May 10 '22 17:05 hanbinyoon

Nit: Could we please initialize a_num_elements to n * n? Something like:

int32_t a_num_elements = n * n; if ((platform == wrapper::Platform::CUDA && side_mode == CUBLAS_SIDE_LEFT) || (platform == wrapper::Platform::ROCm && side_mode == rocblas_side_left)) a_num_elements = m * m;

Otherwise, looks good! :)

Done.

May 10 '22 18:05 rsanthanam-amd