model-analysis icon indicating copy to clipboard operation
model-analysis copied to clipboard

Add test workflow with unittest

Open smokestacklightnin opened this issue 1 year ago • 1 comments

Changes in this PR:

  • Add .gitignore file
  • Add unit test GitHub workflow
  • Add unittest skips or expectedFailures to tests with errors and failures, respectively

You can get a list of tests with skips or expectedFailures using

$ grep -nr "PR 189" tensorflow_model_analysis

There is one import error that I have not dealt with.

smokestacklightnin avatar Oct 23 '24 00:10 smokestacklightnin

@embr This PR seems to me to be ready for review and merge. It just adds a testing workflow. I think fixing the failing tests can come from subsequent work.

The test failure is because of an import error. The import refers to code that is "in maintenance mode" and "not available in TFMA OSS". Until the code becomes present in tfma.eval_saved_model, the tests will not pass.

smokestacklightnin avatar Oct 24 '24 23:10 smokestacklightnin

I'm going to update the branch. If we have failing tests, let's mark them as XFAIL here, then make a PR to remove the missing imports - now that this is officially community maintained, we shouldn't keep tests around for code we will never see here.

peytondmurray avatar Jul 03 '25 14:07 peytondmurray

@peytondmurray Tests are all passing or xfailed!

Will clean up the PR and ping you for review

smokestacklightnin avatar Jul 15 '25 04:07 smokestacklightnin