model-analysis icon indicating copy to clipboard operation
model-analysis copied to clipboard

Breaking changes: tfma.metrics.MetricComputation `preprocessor` argument changed from accepting beam DoFn to `preprocessors` accepting a list of `Preprocessor`

Open EdwardCuiPeacock opened this issue 3 years ago • 1 comments

Recent release of TFMA (0.42 - 0.43 - master) changed the DoFn argument from preprocessor https://github.com/tensorflow/model-analysis/blob/a5c4c709e733bffe10038ee43b07704883d843b1/tensorflow_model_analysis/metrics/metric_types.py#L396 to preprocessors https://github.com/tensorflow/model-analysis/blob/e1c34a8b434440efa32d6617bc922a412c77b924/tensorflow_model_analysis/metrics/metric_types.py#L440

This breaking change is not reflected in the example for custom metrics here.

EdwardCuiPeacock avatar Dec 30 '22 20:12 EdwardCuiPeacock

@EdwardCuiPeacock,

Thank you for pointing this out.

@mdreves, Can you please take a look into custom TFMA metrics example. The example is not updated as per the change in preprocessors attribute in MetricComputation. Thank you!

singhniraj08 avatar Jan 04 '23 07:01 singhniraj08