Fix the wrong computation of dynamic strides for lowering AllocOp to LLVM

Open tungld opened this issue 6 years ago • 2 comments

The computation of dynamic strides in lowering AllocOp was wrong.

Given a MemRefType with sizes = [5, 10], it computed strides = [5, 1], while the correct answer should be strides = [10, 1].

Dec 24 '19 07:12 tungld

Thanks, @ftynse! I removed enumerate.

Dec 28 '19 13:12 tungld

Landed as https://github.com/llvm/llvm-project/commit/e5957ac3d7135eca95b4019eaa394703ad6112a6.

Since MLIR moved to LLVM, please submit your following contributions through https://reviews.llvm.org. Thank you!

@joker-eph could you please close?

Dec 28 '19 22:12 ftynse