mlir icon indicating copy to clipboard operation
mlir copied to clipboard

subview op of mixed shape

Open bondhugula opened this issue 6 years ago • 2 comments

Subview op's with mixed shape (static and dynamic dimensions) currently parse and verify correctly. This is inconsistent given the number of size values that are taken as input. (In the example below, the size of the 2nd dimension of the subview would be undefined -- 8 as per the shape but %arg as per the op that creates the memref).

#map = (d0, d1, d2)[s0, s1, s2] -> (d0 * s2 + d1 * s1 + d2 + s0)

%sv = std.subview %m[%c0, %c0, %c0][%c1, %arg, %c1][%c1, %c1, %c1] : memref<?x8x?xf32> to memref<?x8x?xf32, #map>

bondhugula avatar Nov 20 '19 12:11 bondhugula

Thanks Uday. There is a change to the SubViewOp specification (that should land in github soon). Though that change still missed this case. Will fix this. Thanks!

MaheshRavishankar avatar Nov 20 '19 20:11 MaheshRavishankar

This should be fixed by 750617c8d1faaba503b3f1c288d305ae7525c035

MaheshRavishankar avatar Nov 21 '19 00:11 MaheshRavishankar