mlir icon indicating copy to clipboard operation
mlir copied to clipboard

Update CMakeLists.txt for shared library build

Open stephenneuendorffer opened this issue 6 years ago • 2 comments

There are several circular dependencies between libraries. These are explicitly marked as STATIC. Note that add_llvm_library is redundant with add_dependencies, so we don't have to have libraries in both places.

stephenneuendorffer avatar Sep 11 '19 17:09 stephenneuendorffer

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Sep 11 '19 17:09 googlebot

Hey Stephen,

Could you verify if you've signed the CLA?

Thanks,

Jacques

jpienaar avatar Oct 03 '19 00:10 jpienaar