lucid icon indicating copy to clipboard operation
lucid copied to clipboard

WIP: bugfixes and enhancements to objectives

Open gabgoh opened this issue 6 years ago • 5 comments

New formatting for objectives

>>> a   = f(1)
>>> b   = f(2)
>>> c   = f(3)

>>> a                                                                                                
F(1)

>>> b                                                                                                
F(2)

>>> a + 2*b                                                                                               
(F(1) + F(2)·2·-1)

Access to tensors in after objectives is available now

>>> z = a + 2*b   
>>> z(T)
>>> a.value                                                                                            
 <tf.Tensor 'Mean:0' shape=() dtype=float32>

TODO: Realize is a potentially breaking change to the lower levels of the lucid API. Make sure Ludwig is ok with the changes and all unit tests pass.

gabgoh avatar Feb 04 '19 21:02 gabgoh

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Feb 04 '19 21:02 googlebot

Gabe, please rebase on master@HEAD—I've fixed an unrelated issue with Python 2 compatibility that didn't even let you run the (now still failing) tests in the Python 2 env.

ludwigschubert avatar Feb 04 '19 22:02 ludwigschubert

@googlebot I signed it!

gabgoh avatar Feb 04 '19 23:02 gabgoh

CLAs look good, thanks!

googlebot avatar Feb 04 '19 23:02 googlebot

@gabgoh I'd still happily merge this, but I need a little bit of help. Can you rebase on tensorflow/lucid HEAD? Or transfer the branch from your fork to this repository so I can do so myself?

ludwigschubert avatar Mar 12 '21 15:03 ludwigschubert