java icon indicating copy to clipboard operation
java copied to clipboard

bugs in LossesHelper.removeSqueezableDimensions

Open deansher opened this issue 3 years ago • 3 comments

We execute the following statement if either rank is statically known, but it doesn't give the desired result if the other rank is unknown. https://github.com/tensorflow/java/blob/5532bf0af4a908ee36b6017a8745e515bb3bb544/tensorflow-framework/src/main/java/org/tensorflow/framework/losses/impl/LossesHelper.java#L215

Also, I believe we need to specify the last axis here: https://github.com/tensorflow/java/blob/5532bf0af4a908ee36b6017a8745e515bb3bb544/tensorflow-framework/src/main/java/org/tensorflow/framework/losses/impl/LossesHelper.java#L217 and here: https://github.com/tensorflow/java/blob/5532bf0af4a908ee36b6017a8745e515bb3bb544/tensorflow-framework/src/main/java/org/tensorflow/framework/losses/impl/LossesHelper.java#L219

deansher avatar Feb 27 '21 13:02 deansher

and here: https://github.com/tensorflow/java/blob/5532bf0af4a908ee36b6017a8745e515bb3bb544/tensorflow-framework/src/main/java/org/tensorflow/framework/losses/impl/LossesHelper.java#L123

deansher avatar Mar 13 '21 14:03 deansher

sir, i can help over it

adiroy05 avatar Dec 14 '21 20:12 adiroy05

Please do @adiroy05 , feel free to submit a PR, thanks!

karllessard avatar Dec 15 '21 14:12 karllessard