graphics icon indicating copy to clipboard operation
graphics copied to clipboard

Feature request: NURBS support

Open mpmisko opened this issue 4 years ago • 4 comments

The TF graphics library currently only supports B-Spline interpolation for uniform b-splines. Are there any plans to extend this to Non-Uniform Rational B-Splines (NURBS)? This would essentially mean giving users the option to provide a knot vector together with the control points. In the library, this would involve implementing De Boor's algorithm together with the gradients (a useful resource for b-spline gradients: http://www.stem2.org/je/bspline.pdf).

mpmisko avatar May 10 '20 21:05 mpmisko

Hi @mpmisko

Thanks for reaching out! Would that be something you would be interested to implement and contribute to TensorFlow Graphics? :)

Best.

julienvalentin avatar May 11 '20 15:05 julienvalentin

There is an easy way to add support for NURBS weighted interpolation following this approach: https://pages.mtu.edu/~shene/COURSES/cs3621/NOTES/spline/NURBS/NURBS-def.html. I am more than happy to implement this if you think it is a good idea. :)

mpmisko avatar May 16 '20 18:05 mpmisko

That would be awesome!

julienvalentin avatar Jun 21 '20 07:06 julienvalentin

@mpmisko wish to know if you have started on this topic? If ok, I can join you and share/test the work. [cc: @julienvalentin]

yogeshhk avatar Mar 24 '21 06:03 yogeshhk