gnn icon indicating copy to clipboard operation
gnn copied to clipboard

ROCm support

Open paulamartingonzalez opened this issue 3 years ago • 1 comments

Hi! Do you support ROCm AMD GPUs for this GNN package?

Thanks!

paulamartingonzalez avatar Nov 20 '21 08:11 paulamartingonzalez

hi @paulamartingonzalez ,

In principle GPUs supported by TensorFlow will be supported as well. But we haven't tried it yet.

The tricky part is that for the common GNN case, the library treat things as sparse and rely on tf.gather and the various unsorted segment operations:

https://github.com/tensorflow/gnn/blob/bcc256d47acc9d43f3af2cd4812f19cfde52607d/tensorflow_gnn/graph/graph_tensor_ops.py#L346

Assuming those TF ops are supported for ROCm AMD in TensorFlow, I would expect it to just work, but I'm not sure.

Let us know if you try it -- pls be patient, we are still working on the OSS version, it's very "alpha".

janpfeifer avatar Nov 20 '21 09:11 janpfeifer

Catching up on old issues... It still is like @janpfeifer explained: broadcast and pool (the key operations to move data across GraphTensors) turn into tf.gather and tf.unsorted_segment_<op>, and are executed as usual by core TensorFlow.

At this time, we have no plans to go beyond TensorFlow's built-in support for GPU types, so I'm afraid there is no actionable feature request or defect report here. I hope we could answer your original question. To keep our list of issues manageable, please allow me mark this one as closed.

arnoegw avatar Mar 24 '23 08:03 arnoegw