gan icon indicating copy to clipboard operation
gan copied to clipboard

Google Colab tutorial on Image_GAN.ipynb utilizing tf2.x

Open Ankuraxz opened this issue 4 years ago • 14 comments

https://github.com/tensorflow/gan/issues/18

Ankuraxz avatar Mar 19 '20 15:03 Ankuraxz

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 19 '20 15:03 googlebot

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 19 '20 15:03 googlebot

@googlebot I signed it!

Ankuraxz avatar Mar 19 '20 15:03 Ankuraxz

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 19 '20 15:03 googlebot

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 19 '20 15:03 googlebot

Issue: #18

Code Migrated to TF2.x

Ankuraxz avatar Mar 19 '20 15:03 Ankuraxz

Someone please look on this PR

Ankuraxz avatar Mar 19 '20 15:03 Ankuraxz

Can anyone help me with import/copybara

Ankuraxz avatar Mar 19 '20 15:03 Ankuraxz

Hi Ankuraxz,

  • You can move Collab_tutorial_on_GAN_using_tf2_x.ipynb to tensorflow_gan/examples/colab_notebooks/
  • Talking about tensorflow_gan/Image_GAN/Image_GAN.md. It does not seem necessary. You should document about code in the notebook itself.
  • Please insert LICENSE snippet at starting of file. eg. (Below given is just example)

# Copyright 2018 The TensorFlow GAN Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# ==============================================================================
  • I think you can disregard copybara for a while. Read about copybara from here

merrcury avatar Mar 20 '20 08:03 merrcury

Okk thanks 👍

Ankuraxz avatar Mar 20 '20 10:03 Ankuraxz

Issue: #18

Code Migrated to TF2.x

Ankuraxz avatar Mar 20 '20 11:03 Ankuraxz

Issue: #18

Code Migrated to TF2.x

Ankuraxz avatar Mar 20 '20 11:03 Ankuraxz

@merrcury Thank you very much for your help

Ankuraxz avatar Mar 20 '20 11:03 Ankuraxz