gan icon indicating copy to clipboard operation
gan copied to clipboard

Published 20 hours ago • verified publisher icon tensorflow

tfgan_tutorial.ipynb Compatible with TF2.x

Open ayushmankumar7 opened this issue 5 years ago • 6 comments

Issue: #18

Code Migrated to TF2.x

ayushmankumar7 avatar Feb 27 '20 15:02 ayushmankumar7

Someone please check this PR

ayushmankumar7 avatar Mar 02 '20 09:03 ayushmankumar7

This change is good in theory, but I think the same can be achieved by changing the single line "import tensorflow as tf" to "import tensorflow.compat.v1 as tf", which is the preferred way of setting the version. Would you mind doing this instead?

joel-shor avatar Mar 04 '20 01:03 joel-shor

No Problem. I ll make the respective changes and commit it.

ayushmankumar7 avatar Mar 04 '20 04:03 ayushmankumar7

@joel-shor It's done.

ayushmankumar7 avatar Mar 04 '20 04:03 ayushmankumar7

I can't review this with all the changes in output causing noise. Can you just change code, not the outputs, so that I can review it? Or else if you hav a suggestion on how to review this without that, please let me know.

joel-shor avatar Mar 08 '20 04:03 joel-shor

@joel-shor It's done I have just changed the code. Left the output as it is.

ayushmankumar7 avatar Mar 08 '20 08:03 ayushmankumar7