examples icon indicating copy to clipboard operation
examples copied to clipboard

fixing the loss syntax for l02c01

Open bitekas opened this issue 4 years ago • 5 comments

Replacing the magic string constant with the canonical class name. The previous format would cause incorrect code to compile but fail at runtime. The updated version checks the syntax on the compilation phase. The exact class string code is an implementation detail and may change in the future making the example invalid.

bitekas avatar Dec 23 '20 03:12 bitekas

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Dec 23 '20 03:12 google-cla[bot]

@googlebot I signed it!

bitekas avatar Dec 23 '20 04:12 bitekas

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Dec 23 '20 04:12 google-cla[bot]

@googlebot I fixed it.

bitekas avatar Mar 15 '23 06:03 bitekas