ecosystem icon indicating copy to clipboard operation
ecosystem copied to clipboard

support ArrayType(StringType, _) for SequenceExample

Open zhangxuhong opened this issue 5 years ago • 7 comments

zhangxuhong avatar Jun 20 '19 00:06 zhangxuhong

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jun 20 '19 00:06 googlebot

i signed

zhangxuhong avatar Jun 20 '19 00:06 zhangxuhong

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Jun 20 '19 00:06 googlebot

@skavulya Would you mind taking a look if you have time?

@zhangxuhong Mind adding a test?

jhseu avatar Jun 20 '19 18:06 jhseu

@jhseu Thanks for taking a look at it. If this issue can be confirmed, i will add the corresponding tests.

zhangxuhong avatar Jun 24 '19 16:06 zhangxuhong

@zhangxuhong Thanks for the contribution. I'll take a look at it this evening to confirm the issue.

skavulya avatar Jun 24 '19 16:06 skavulya

@zhangxuhong Yes, this is an issue. Please add the unit tests. Thanks.

skavulya avatar Oct 29 '19 18:10 skavulya