ecosystem icon indicating copy to clipboard operation
ecosystem copied to clipboard

ArrayType(StringType) is not supported when writing to SequenceExample

Open zhangxuhong opened this issue 5 years ago • 2 comments

https://github.com/tensorflow/ecosystem/blob/12d65f29b29a1b5bc975d9c11745b6e67818a6ae/spark/spark-tensorflow-connector/src/main/scala/org/tensorflow/spark/datasources/tfrecords/serde/DefaultTfRecordRowEncoder.scala#L96

This line of code indicates that ArrayType(StringType, _) will be encoded to FeatureList, however, method encodeFeatureList does not handle this case, and will throw exception. https://github.com/tensorflow/ecosystem/blob/12d65f29b29a1b5bc975d9c11745b6e67818a6ae/spark/spark-tensorflow-connector/src/main/scala/org/tensorflow/spark/datasources/tfrecords/serde/DefaultTfRecordRowEncoder.scala#L194

Is this on purpose or a bug?

zhangxuhong avatar Jun 19 '19 05:06 zhangxuhong

Hello, any news regarding this ?

bamine avatar Jul 23 '19 22:07 bamine

I have same issue. The documentation is also lying about this because it says that ArrayType(SringType) is supported.

nicholas-leonard avatar Jun 17 '20 16:06 nicholas-leonard