docs icon indicating copy to clipboard operation
docs copied to clipboard

formula fix

Open jancervenka opened this issue 2 years ago • 2 comments

In the gradient descent with momentum formula, I think the gradient function $L^\prime$ should use $x^{[t-1]}$ to cumpute the new delta.

$$ \Delta_x^{[t]} = lr \cdot L^\prime(x^{[t-1]}) + p \cdot \Delta_x^{[t-1]} $$

jancervenka avatar Sep 23 '22 09:09 jancervenka

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-1

github-actions[bot] avatar Sep 23 '22 09:09 github-actions[bot]

@MarkDaoust @markmcd PTAL

8bitmp3 avatar Oct 03 '22 17:10 8bitmp3

LGTM. The whole point is to calculate $x^{[t]}$, so that makes sense.

Thanks for the fix.

markmcd avatar Oct 21 '22 07:10 markmcd