agents icon indicating copy to clipboard operation
agents copied to clipboard

Bias Layer: Add support for regularizer and constraint

Open saisua opened this issue 3 years ago • 3 comments

Small patch to add the bias_regularizer and bias_constraint. It is needed to be like other layers in TF2.0. They are initialized as None based on current master.

saisua avatar Apr 05 '22 12:04 saisua

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar Apr 05 '22 12:04 google-cla[bot]

I just did that. Thank you for your quick response. As a side note, I have seen that there is a file called something like "bias layer test". I have not touched it but feel free to ask for anything.

saisua avatar Apr 05 '22 12:04 saisua

Please add 2 new test to make sure the new arguments work as expected.

sguada avatar Apr 05 '22 12:04 sguada

This has been about 1.5 years. I am making this closed. We can always reopen. I am merging PRs where with my knowledge can get the merged. This one is too big for me to handle unfortunately. Sometimes things rot on the vine; sad and a reality.

Thank you for the effort and sorry this did not make it to the finish.

tfboyd avatar Sep 30 '23 13:09 tfboyd