agents icon indicating copy to clipboard operation
agents copied to clipboard

Published 20 hours ago • verified publisher icon tensorflow

Add MultiCategoricalProjectionNetwork

Open sidney-tio opened this issue 3 years ago • 3 comments

Closes #694

sidney-tio avatar Feb 12 '22 19:02 sidney-tio

@sidney-tio Thank you for this PR. It could also solve #702 for me. Hope that this will be merged soon.

sibyjackgrove avatar Feb 22 '22 02:02 sibyjackgrove

hi team! could i request a review for this please?

sidney-tio avatar Mar 31 '22 11:03 sidney-tio

thanks for the review! made the changes as advised. Some of the changes requested were for code inherited from CategoricalProjectionNetwork, so I'm not sure if it warrants a separate PR to reconcile both?

sidney-tio avatar Apr 06 '22 19:04 sidney-tio

@sguada Is there a reason this was never merged? I think this one would make such a difference.

MiriamJo avatar Jul 14 '23 07:07 MiriamJo

Closing, after this much time I do not think anyone will get to it. I am merging others that I can review myself. This one is too big for me. Sorry this one got so far and didn't land. :-(

tfboyd avatar Sep 30 '23 13:09 tfboyd

@sguada just for visibility.

tfboyd avatar Sep 30 '23 13:09 tfboyd