addons icon indicating copy to clipboard operation
addons copied to clipboard

Fix static shape check in crd_decode

Open vankov opened this issue 2 years ago • 3 comments

When checking whether the shape of 'potentials' is static in crf_decode, you need to check whether potentials.shape[1].value is None, and not potentials.shape[1] (which is a Dimension object and is never equal to None).

Description

Brief Description of the PR:

Fixes # (issue)

Type of change

Checklist:

  • [ ] I've properly formatted my code according to the guidelines
    • [ ] By running Black + Flake8
    • [ ] By running pre-commit hooks
  • [ ] This PR addresses an already submitted issue for TensorFlow Addons
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:

I've checked the resulting graphs using both static and dynamic shapes with and feeding either single item or multiple item sequences.

vankov avatar Aug 26 '22 12:08 vankov

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 26 '22 12:08 google-cla[bot]

@howl-anderson

You are owner of some files modified in this pull request. Would you kindly review the changes whenever you have the time to? Thank you very much.

Do you have a test extension to cover/check your case?

bhack avatar Aug 26 '22 13:08 bhack