addons icon indicating copy to clipboard operation
addons copied to clipboard

whether the return value of crf in the call function needs to be the same In the stage of train and valid ?

Open colynhn opened this issue 3 years ago • 4 comments

hello, @howl-anderson :

May i ask you some questions? Details are as follows:

file path: https://github.com/howl-anderson/addons/blob/feature/crf_layer_on_stable_release/tensorflow_addons/layers/crf.py: code: def call(self, inputs, mask=None, text=None, **kwargs):

the call func return value is always decoded_sequence in the train and valid phase, but in the keras-contrib (keras-contrib/keras_contrib/layers/crf.py): the call func is defined as "out = K.in_train_phase(train_output, test_output)", it is diffient in the train and valid phase, so i have doubts about whether the return value of crf in the call function needs to be the same In the stage of train and valid?

Looking forward to everyone's answers, thx.

colynhn avatar Oct 12 '21 09:10 colynhn

/cc @howl-anderson

bhack avatar Oct 12 '21 17:10 bhack

Thank you @bhack for mention me. H, @colynhn thank you for your question, I will do some investigation on this (due to the outdated codebase), and feedback here when it's done.

howl-anderson avatar Oct 14 '21 02:10 howl-anderson

@howl-anderson Ok, looking forward to your future results, thank you.

colynhn avatar Oct 14 '21 06:10 colynhn

H, @howl-anderson Is there any conclusion to this question? thank you.

colynhn avatar Dec 21 '21 08:12 colynhn