Performance issue in the definition of test_crf_log_likelihood, tensorflow_addons/text/tests/crf_test.py(P1)

[DLPerf]

Hello, I found a performance issue in the definition of test_crf_log_likelihood, tensorflow_addons/text/tests/crf_test.py, tf.expand_dims will be called repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.

The same issues exist in

• tf.expand_dims(sequence_lengths, 0) in line 315;

• tf.expand_dims(inputs, 0) in line 349;

• tf.expand_dims(sequence_lengths, 0) in line 351.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

[DLPerf]

@eli-osherovich Hi, my friend, could you consider my issue asap?

[bhack]

/cc @howl-anderson

[howl-anderson]

@DLPerf Thank you for your reporting. I will take a closer look on it and I will keep you posted.

[howl-anderson]

@bhack @DLPerf Since this issue only affect testing not the CRF function itself and we have some high priority tasks for CRF (critical bugfix #2476 / refactor #2271 / tutorial #2552 / model wrapper #2555) need be done. So, I mark this issue as low priority. But don't worry, this issue is tracked and on my radar.

[seanpmorgan]

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision: TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA: Keras Keras-CV Keras-NLP