addons icon indicating copy to clipboard operation
addons copied to clipboard

Published 20 hours ago • verified publisher icon tensorflow

Added Multi Similarity loss

Open ashutosh1919 opened this issue 5 years ago • 21 comments

Fixes #1017 .
@shun-lin, @seanpmorgan - Please review.

Also, Suggest me how to write the tests for this loss. Please suggest the way in which I should proceed to write good tests for it.

ashutosh1919 avatar Apr 16 '20 06:04 ashutosh1919

Hi @ashutosh1919 thanks for taking up this PR! I would suggest looking at how the other losses are implementing their tests for your test cases.

shun-lin avatar Apr 16 '20 18:04 shun-lin

@shun-lin - I have added tests. Please review.

ashutosh1919 avatar Apr 17 '20 07:04 ashutosh1919

@shun-lin - Done changes. Please review.

ashutosh1919 avatar Apr 18 '20 04:04 ashutosh1919

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot avatar Apr 18 '20 07:04 googlebot

@autoih , Thanks for noticing mistake. Please sign your CLA.

ashutosh1919 avatar Apr 18 '20 07:04 ashutosh1919

@shun-lin - can you manually approve CLA since there is no reply from @autoih .

ashutosh1919 avatar Apr 20 '20 02:04 ashutosh1919

@googlebot I fixed it.

autoih avatar Apr 20 '20 04:04 autoih

@autoih , Please sign the CLA with all the email IDs you are logged into your system. I had the same issue. But it resolves the issue.

ashutosh1919 avatar Apr 20 '20 06:04 ashutosh1919

@googlebot I fixed it.

autoih avatar Apr 20 '20 16:04 autoih

@autoih , Please sign the CLA with all the email IDs you are logged into your system. I had the same issue. But it resolves the issue.

@ashutosh1919, I think I did, but not sure why it has the issue still.

autoih avatar Apr 20 '20 16:04 autoih

Apologies, I haven't had the time to review as much as I would like... but just wanted to comment that the CLA is not an issue. We can override it during merge since you're both active contributors that have signed the CLA.

seanpmorgan avatar Apr 23 '20 03:04 seanpmorgan

Thanks @seanpmorgan for the comment.

ashutosh1919 avatar Apr 23 '20 03:04 ashutosh1919

@ashutosh1919 do you also want to add a tutorial (notebook) for this loss as well?

shun-lin avatar Apr 23 '20 23:04 shun-lin

@shun-lin , Okay let me add.

ashutosh1919 avatar Apr 24 '20 11:04 ashutosh1919

Please ignore below images. Just uploaded for retrieving links to paste in notebook.

ashutosh1919 avatar Apr 24 '20 11:04 ashutosh1919

ms_loss_steps ms_loss_equation

ashutosh1919 avatar Apr 24 '20 12:04 ashutosh1919

@shun-lin - Please review.

ashutosh1919 avatar Apr 24 '20 12:04 ashutosh1919

@shun-lin - Any update on this PR? Thanks!

ashutosh1919 avatar Apr 28 '20 11:04 ashutosh1919

I would like very much to try this metric ! Is there a reason why the PR is frozen ?

MathisFederico avatar Jul 11 '20 15:07 MathisFederico

Hi sorry, somehow notification for this PR fall through my gmail filter, will review! Sorry for the delay.

shun-lin avatar Jul 11 '20 15:07 shun-lin

@shun-lin - Changes made. Please review.

ashutosh1919 avatar Jul 12 '20 11:07 ashutosh1919

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision: TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA: Keras Keras-CV Keras-NLP

seanpmorgan avatar Mar 01 '23 04:03 seanpmorgan