adanet icon indicating copy to clipboard operation
adanet copied to clipboard

adanet.ensemble.Ensembler not used in Tutorials?

Open le-dawg opened this issue 5 years ago • 5 comments

~~Obsolete~~ Apparently I was incorrect in my assessment! @cweill I have been stumbling upon discrepancies between docs and code a few times in the examples and I want to phrase this as a question:

# TODO: Delete deprecated build_mixture_weights_train_op method.
# Use adanet.ensemble.Ensembler instead.

According to the doc and original paper this would imply that the tutorials actually do not form ensembles. Is that the case?

le-dawg avatar Apr 07 '20 16:04 le-dawg

@le-dawg I think you make a good point: we need to update our tutorials to use the tf.ensemble.Ensemblers.

cweill avatar Apr 07 '20 16:04 cweill

Updated OP.

le-dawg avatar Apr 07 '20 16:04 le-dawg

Can you point me to any reference implementation? I have deriived my Builder and Generator classes from the tutorial definition but I am stuck trying to determine wehterh and als HOW my AdaNet instance is Ensembling. Given that build.mixtureweight doesnt compute anything I wonder what the final ensembles look like. @cweill

le-dawg avatar Apr 14 '20 19:04 le-dawg

Edited the typos, I have a freshly fractured hand :/

le-dawg avatar Apr 14 '20 19:04 le-dawg

According to the doc and original paper this would imply that the tutorials actually do not form ensembles. Is that the case?

They still create ensembles, it just that we now use the adanet.ensemble.Ensembler suclasses to handle this feature. In the tutorials, they were using the old method with the build_mixture_weights. The same behavior can be found in the adanet.ensemble.ComplexityRegularizedEnsembler class, which will create one new candidate ensemble per subnetwork per iteration, where the ensemble is composed of the previous iteration's ensemble and new subnetwork.

cweill avatar Apr 17 '20 22:04 cweill